Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Support Non-Table Models #985

Closed
wants to merge 4 commits into from
Closed

[2.x] Support Non-Table Models #985

wants to merge 4 commits into from

Conversation

ravage84
Copy link
Member

Alternative branch to #953
I couldn't push my changes to @asgraf's PR branch, thus added the requested test coverage changes by @markstory in a new branch on the origin repo.

If these changes do not satisfy, please feel free to amend and extend my additions.

Ping back @dereuromark

@ravage84 ravage84 added this to the 2.x (CakePHP 4) milestone Apr 26, 2024
@ravage84
Copy link
Member Author

May be typeCanDetectFixtures() should to be widened, too

But this could be implemented separately, I guess.

@ravage84 ravage84 mentioned this pull request Apr 26, 2024
Merged
@ravage84
Copy link
Member Author

ravage84 commented Apr 26, 2024 •
edited
Loading

One issue with the test suite seem unrelated. Fixed in #986

PR needs to be updated, once merged.

@ravage84
Copy link
Member Author

ravage84 commented Apr 26, 2024 •
edited
Loading

I did not update the code criticized by PHPStan:

Error: Call to an undefined method Cake\Datasource\RepositoryInterface::getAssociation().
Error: Result of && is always false.
Error: Strict comparison using === between NEVER and class-string|false will always evaluate to false.

https://github.com/cakephp/bake/actions/runs/8847219659/job/24294625577?pr=985#step:7:13

@dereuromark
Copy link
Member

We should probably finish and merge
#952
first, as that one is the Cake 5.x branch, this here 4.x one.

@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open 30 days with no activity. Remove the stale label or comment on this issue, or it will be closed in 15 days

@github-actions github-actions bot added the stale label Aug 26, 2024
@dereuromark dereuromark deleted the support-non-table-models branch August 26, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereuromark dereuromark dereuromark approved these changes

Assignees
No one assigned
Labels
enhancement stale
Projects
None yet
Milestone
2.x (CakePHP 4)
Development

Successfully merging this pull request may close these issues.
3 participants
@ravage84 @dereuromark @asgraf